Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kompute : fix rope_f32 and scale ops #5008

Merged
merged 1 commit into from
Jan 18, 2024
Merged

kompute : fix rope_f32 and scale ops #5008

merged 1 commit into from
Jan 18, 2024

Conversation

ggerganov
Copy link
Owner

Fixes:

./bin/test-backend-ops -o ROPE -b Kompute        (f32 only)
./bin/test-backend-ops -o SCALE -b Kompute

@cebtenzzre
Copy link
Collaborator

Oh, cool, thanks for looking at this! There are known issues with Falcon on GPT4All, maybe this fixes them. The F16 RoPE kernel presumably needs the same changes - but I can merge this and do that myself if you'd like.

@cebtenzzre cebtenzzre merged commit 696faa8 into ceb/nomic-vulkan Jan 18, 2024
35 of 45 checks passed
@cebtenzzre cebtenzzre deleted the ceb/nomic-vulkan-fixes branch January 18, 2024 16:49
cebtenzzre pushed a commit that referenced this pull request Jan 24, 2024
@ggerganov @cebtenzzre
kompute : fix rope_f32 and scale ops (#5008)
d6bd471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @cebtenzzre