Use params when loading models in llava-cli #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llava-cli was loading models with default params and ignoring settings from the cli. This switches to a generic function to load the params from the cli options.
|
Hey small PR here, I wrote a quick fix when I noticed that the model wasn't using my GPU for offloading layers even though I had the setting on the cli. |
|
Thanks, a regression in #3613 |
monatis
approved these changes
Nov 7, 2023
|
Np, appreciate the quick turn around time! |
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
llava-cli was loading models with default params and ignoring settings from the cli. This switches to a generic function to load the params from the cli options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llava-cli was loading models with default params and ignoring settings from the cli. This switches to a generic function to load the params from the cli options.