Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix perplexity after c-api refactor #390

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix perplexity after c-api refactor #390

merged 2 commits into from
Mar 22, 2023

Conversation

Green-Sky
Copy link
Collaborator

@Green-Sky Green-Sky commented Mar 22, 2023 •
edited
Loading

fixes #385
replaces #389

@Green-Sky Green-Sky added the bug Something isn't working label Mar 22, 2023
@Green-Sky Green-Sky mentioned this pull request Mar 22, 2023
Closed
4 tasks
@Green-Sky Green-Sky requested a review from ggerganov March 22, 2023 16:07
ggerganov
ggerganov approved these changes Mar 22, 2023
View reviewed changes
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea for limiting the max number of tokens!

@ggerganov ggerganov merged commit 56e659a into ggerganov:master Mar 22, 2023
@Green-Sky Green-Sky deleted the fix_for_perplexity_tok branch May 1, 2023 10:23
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
@abetlen
Merge pull request ggerganov#390 from SubhranshuSharma/main
15e0e0a 
added termux with root instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute perplexity fails with too many tokens exception
2 participants
@Green-Sky @ggerganov