Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLBlast_DIR var. #3330

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix CLBlast_DIR var. #3330

merged 1 commit into from
Sep 25, 2023

Conversation

fossilet
Copy link
Contributor

CLBlast_dir would not be recognized.

CMake Warning:
  Manually-specified variables were not used by the project:

    CLBlast_dir

@Green-Sky
Copy link
Collaborator

fixes #2034 (kinda)

@Green-Sky Green-Sky requested a review from SlyEcho September 25, 2023 15:08
@SlyEcho
Copy link
Collaborator

SlyEcho commented Sep 25, 2023

I always used CMAKE_PREFIX_PATH for this.

SlyEcho
SlyEcho approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@SlyEcho SlyEcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the correct flag.

@Green-Sky Green-Sky merged commit 1726f96 into ggerganov:master Sep 25, 2023
@fossilet fossilet deleted the patch-1 branch September 26, 2023 00:47
pkrmf pushed a commit to morlockstudios-com/llama.cpp that referenced this pull request Sep 26, 2023
@pkrmf
docs: Fix typo CLBlast_DIR var. (ggerganov#3330)
f160081
joelkuiper added a commit to vortext/llama.cpp that referenced this pull request Sep 27, 2023
@joelkuiper
Merge branch 'master' of github.com:ggerganov/llama.cpp into grammar-…
ba11eb9 
…example

* 'master' of github.com:ggerganov/llama.cpp:
  convert : remove bug in convert.py permute function (ggerganov#3364)
  make-ggml.py : compatibility with more models and GGUF (ggerganov#3290)
  gguf : fix a few general keys (ggerganov#3341)
  metal : reusing llama.cpp logging (ggerganov#3152)
  build : add ACCELERATE_NEW_LAPACK to fix warning on macOS Sonoma (ggerganov#3342)
  readme : add some recent perplexity and bpw measurements to READMES, link for k-quants (ggerganov#3340)
  cmake : fix build-info.h on MSVC (ggerganov#3309)
  docs: Fix typo CLBlast_DIR var. (ggerganov#3330)
  nix : add cuda, use a symlinked toolkit for cmake (ggerganov#3202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlyEcho SlyEcho SlyEcho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fossilet @Green-Sky @SlyEcho