ggml-opencl : store GPU buffer in ggml_tensor::extra #2994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggml-opencl
currently stores the GPU buffer inggml_tensor::data
, and after the GGUF changes this will result in a memory leak when not using mmap, as the address of the CPU buffer is lost after the call toggml_cl_transform_tensor
:llama.cpp/llama.cpp
Lines 1516 to 1523 in 47068e5
This change solves that issue and a possible interaction with
ggml-alloc
if the opencl buffer falls within the measure buffer memory range by storing the GPU buffer inggml_tensor::extra
instead.Fixes #2993