Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama.h: add missing struct keyword for C compat in callback type #2847

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

igarnier
Copy link
Contributor

Fixes C compatibility (Tested with gcc 11.3.0 on linux)

@cebtenzzre
Copy link
Collaborator

cebtenzzre commented Aug 28, 2023

We're getting a lot of these PRs lately. Maybe we could set up CI to run gcc -xc -c llama.h -o /dev/null to check for C compliance?

@igarnier
Copy link
Contributor Author

A CI would be nice, or perhaps just a dummy target in the Makefile?

@ggerganov ggerganov merged commit dd0dc36 into ggerganov:master Aug 28, 2023
akawrykow pushed a commit to akawrykow/llama.cpp that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants