Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use ccache on windows HIP jobs #11553

Merged
merged 3 commits into from
Feb 1, 2025
Merged

ci: use ccache on windows HIP jobs #11553

merged 3 commits into from
Feb 1, 2025

Conversation

ochafik
Copy link
Collaborator

@ochafik ochafik commented Jan 31, 2025 •
edited
Loading

Revert windows HIP build to plain ccache, which seems to work (despite caveats about windows support for the github action).

Also tried CMAKE_HIP_COMPILER_LAUNCHER described in ROCm/ROCm#2817, in vain.

ref

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jan 31, 2025
@github-actions github-actions bot added the devops improvements to build systems and github actions label Jan 31, 2025
@ochafik ochafik marked this pull request as ready for review February 1, 2025 18:20
@ochafik ochafik changed the title ci: attempt to use sccache + HIP ci: use sccache on windows HIP jobs Feb 1, 2025
@ochafik ochafik merged commit 53debe6 into ggerganov:master Feb 1, 2025
41 checks passed
@ochafik ochafik changed the title ci: use sccache on windows HIP jobs ci: use ccache on windows HIP jobs Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ochafik @slaren