Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github protocol pulling and http:// #11465

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Add github protocol pulling and http:// #11465

merged 1 commit into from
Jan 28, 2025

Conversation

ericcurtin
Copy link
Collaborator

As pulling protocols to llama-run

@ericcurtin ericcurtin force-pushed the github-protocol branch 2 times, most recently from 1a1343d to 15cae73 Compare January 28, 2025 11:55
As pulling protocols to llama-run

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
@ggerganov
Copy link
Owner

Btw, it would be great QoL if the llama-run command does not re-download a model when using a remote link. Do you plan to implement this?

@ericcurtin
Copy link
Collaborator Author

ericcurtin commented Jan 28, 2025

Btw, it would be great QoL if the llama-run command does not re-download a model when using a remote link. Do you plan to implement this?

We added this recently on line 326:

if (std::filesystem::exists(output_file))

which should do this, unless you found a bug @ggerganov 😅

@ericcurtin ericcurtin merged commit 7fee288 into master Jan 28, 2025
45 checks passed
@ericcurtin ericcurtin deleted the github-protocol branch January 28, 2025 14:45
@ggerganov
Copy link
Owner

It works now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants