Hip: disable VMM on hip as it seams that it dosent work in some configurations #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
reviewed
Jan 25, 2025
| @@ -155,6 +155,7 @@ option(GGML_CUDA_GRAPHS "ggml: use CUDA graphs (llama.cpp on | |||
|
|
|||
| option(GGML_HIP "ggml: use HIP" OFF) | |||
| option(GGML_HIP_GRAPHS "ggml: use HIP graph, experimental, slow" OFF) | |||
| option(GGML_HIP_NO_VMM "ggml: do not try to use HIP VMM" ON) | |||
There was a problem hiding this comment.
At some point we should rename all the negative options (e.g. GGML_CUDA_NO_VMM -> GGML_CUDA_VMM) and set the default value accordingly instead. This is mostly an artifact from the time Makefile was used and didn't have a good way to set defaults.
slaren
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it seams that this dosent work on some configurations #11405 and we have no way of telling which, lets disable this by default.