-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci : pin dependency to specific version #11137
Conversation
Hmm, the action for |
Alright, this fixed the editorconfig workflow |
Btw, while at this, should we move the release action to the llama.cpp/.github/workflows/build.yml Lines 1238 to 1242 in 02f0430
|
Yeah we should, for security reason. |
Hmm no sorry, they do have: https://github.com/actions/create-release
|
Oh I didn't see, it's deprecated. We should make a fork in ggml-org then. |
Let's fork or clone https://github.com/anzz1/action-create-release to |
Done: https://github.com/ggml-org/action-create-release Maybe we should do the same for all actions that can modify the output artifacts. Not sure if there is any other than the |
Yup it would be nice if you can fork these actions too:
Thanks. |
I forked the https://github.com/ggml-org/free-disk-space. The https://github.com/hendrikmuhs/ccache-action repo seems to be active, so I guess it is OK to keep using the source repo. |
Pin some workflows to specific version, for better security and stability.
This also fixes the problem with latest editorconfig version, ref: editorconfig-checker/editorconfig-checker#409