Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : pin dependency to specific version #11137

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Jan 8, 2025

Pin some workflows to specific version, for better security and stability.

This also fixes the problem with latest editorconfig version, ref: editorconfig-checker/editorconfig-checker#409

@ngxson ngxson requested a review from ggerganov January 8, 2025 10:50
@github-actions github-actions bot added the devops improvements to build systems and github actions label Jan 8, 2025
@ngxson ngxson marked this pull request as draft January 8, 2025 10:55
@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Hmm, the action for editorconfig-checker only have v2 tag, but the underlay package has multiple versions. This is a bad practice, I'll need to adapt this.

@ngxson ngxson marked this pull request as ready for review January 8, 2025 11:06
@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Alright, this fixed the editorconfig workflow

@ngxson ngxson merged commit 80ccf5d into ggerganov:master Jan 8, 2025
2 checks passed
@ggerganov
Copy link
Owner

ggerganov commented Jan 8, 2025

Btw, while at this, should we move the release action to the ggml-org organization:

- name: Create release
id: create_release
uses: anzz1/action-create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Yeah we should, for security reason. Actually I was surprised because github does not have an official action for that.

@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Hmm no sorry, they do have: https://github.com/actions/create-release

We should use this one then

@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Oh I didn't see, it's deprecated. We should make a fork in ggml-org then.

@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Let's fork or clone https://github.com/anzz1/action-create-release to ggml-org

@ggerganov
Copy link
Owner

Let's fork or clone anzz1/action-create-release to ggml-org

Done: https://github.com/ggml-org/action-create-release

Maybe we should do the same for all actions that can modify the output artifacts. Not sure if there is any other than the action-create-release.

@ngxson
Copy link
Collaborator Author

ngxson commented Jan 8, 2025

Yup it would be nice if you can fork these actions too:

Thanks.

@ggerganov
Copy link
Owner

I forked the https://github.com/ggml-org/free-disk-space. The https://github.com/hendrikmuhs/ccache-action repo seems to be active, so I guess it is OK to keep using the source repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants