server: add flag to disable the web ui #10751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b7ad5f to
4e608be
Compare
|
@ggerganov @VJHack how do I assign reviewers to PRs? Thanks! |
4 tasks
4e608be to
023baf8
Compare
ngxson
approved these changes
Dec 10, 2024
005a487 to
e6f42b1
Compare
|
@ngxson what is the process for merging PRs? I really appreciate your help! |
|
It depends on which part of the project. For simple changes like this one, it can be merged if the coding style is good and CI passes. Adding test cases is optional, but is highly recommended |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
…10751) Co-authored-by: eugenio.segala <esegala@deloitte.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to disable the web ui. As the server will be production ready one day, I think it's fair that someone (i.e: me) does not want the web ui to be visible.
Add: #10762