SYCL: Fix and switch to GGML_LOG system instead of fprintf #10579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Nov 29, 2024
airMeng
approved these changes
Dec 2, 2024
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Dec 7, 2024
…#10579) * Switched to GGML_LOG * Fix missing semicolon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @NeoZhangJianyu @airMeng This should have been done way earlier but I ended by doing it by myself. I intend to keep on optimizing the SYCL codebase time to time whenever I get time since I am noticing that it gets far less attention in comparison to other backends. :)