Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama : use cmake for swift build #10525

Merged
merged 8 commits into from
Dec 8, 2024
Merged

llama : use cmake for swift build #10525

merged 8 commits into from
Dec 8, 2024

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Nov 26, 2024 •
edited
Loading

This is intended to show a possible way to use cmake to build the llama.cpp dependency for the swift code, without having to duplicate the build in Package.swift.

@github-actions github-actions bot added build Compilation issues devops improvements to build systems and github actions labels Nov 26, 2024
@slaren slaren force-pushed the sl/swift-cmake-test branch 2 times, most recently from a73ca52 to 27432b6 Compare November 26, 2024 18:50
@ggerganov ggerganov mentioned this pull request Dec 2, 2024
Merged
@ggerganov ggerganov force-pushed the sl/swift-cmake-test branch from 27432b6 to 47844dc Compare December 7, 2024 19:13
@ggerganov ggerganov marked this pull request as ready for review December 7, 2024 20:49
@ggerganov ggerganov merged commit 43ed389 into master Dec 8, 2024
47 checks passed
@jiabochao jiabochao mentioned this pull request Dec 10, 2024
Open
@slaren slaren deleted the sl/swift-cmake-test branch December 10, 2024 20:55
@pgorzelany
Copy link

Hi @slaren sorry to bother you but this MR broke the Swift package integration. See more details here: #10747

MrMage added a commit to MrMage/llama.cpp that referenced this pull request Dec 13, 2024
@MrMage
Revert "llama : use cmake for swift build (ggerganov#10525)"
5b4eda0 
This reverts commit 43ed389.
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
@slaren @ggerganov @arthw
llama : use cmake for swift build (ggerganov#10525)
fd9cf67 
* llama : use cmake for swift build

* swift : <> -> ""

* ci : remove make

* ci : disable ios build

* Revert "swift : <> -> """

This reverts commit d39ffd9.

* ci : try fix ios build

* ci : cont

* ci : cont

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
MrMage added a commit to MrMage/llama.cpp that referenced this pull request Jan 27, 2025
@MrMage
Revert "llama : use cmake for swift build (ggerganov#10525)"
2ad9162 
This reverts commit 43ed389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Compilation issues devops improvements to build systems and github actions examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slaren @pgorzelany @ggerganov