Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HIP flag inconsistency & build docs #10524

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix HIP flag inconsistency & build docs #10524

merged 2 commits into from
Nov 26, 2024

Conversation

tristandruyen
Copy link
Contributor

@tristandruyen tristandruyen commented Nov 26, 2024 •
edited
Loading

Seems like this was missed in #10256.

  • renames GGML_HIPBLAS to GGML_HIP in Makefile so it is consistent with CMakelists.txt and everywhere else.
  • fixes build docs

Related: ggml-org/ggml#1029

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 26, 2024
@tristandruyen tristandruyen mentioned this pull request Nov 26, 2024
Merged
@slaren slaren merged commit be0e350 into ggerganov:master Nov 26, 2024
53 of 54 checks passed
brianredbeard added a commit to brianredbeard/llama.cpp that referenced this pull request Dec 18, 2024
@brianredbeard
docs: Fix HIP (née hipBLAS) in README
3642327 
Related to ggerganov#10524 / be0e350 references to hipBLAS have been removed
across the repository.  This fixes the link from the repositories
`README.md`.

Signed-off-by: Brian 'redbeard' Harrington <redbeard@dead-city.org>
@brianredbeard brianredbeard mentioned this pull request Dec 18, 2024
Merged
ggerganov pushed a commit that referenced this pull request Dec 18, 2024
@brianredbeard
docs: Fix HIP (née hipBLAS) in README (#10880)
6b064c9 
Related to #10524 / be0e350 references to hipBLAS have been removed
across the repository.  This fixes the link from the repositories
`README.md`.

Signed-off-by: Brian 'redbeard' Harrington <redbeard@dead-city.org>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
@tristandruyen @arthw
Fix HIP flag inconsistency & build docs (ggerganov#10524)
0f185c5 
* Fix inconsistency of HIP flags in cmake & make

* Fix docs regarding GGML_HIP
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
@brianredbeard @arthw
docs: Fix HIP (née hipBLAS) in README (ggerganov#10880)
49c08d5 
Related to ggerganov#10524 / be0e350 references to hipBLAS have been removed
across the repository.  This fixes the link from the repositories
`README.md`.

Signed-off-by: Brian 'redbeard' Harrington <redbeard@dead-city.org>
@HiroseKoichi HiroseKoichi mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristandruyen @slaren