-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: (web UI) Add samplers sequence customization #10255
Conversation
examples/server/public/index.html
Outdated
@@ -227,6 +227,15 @@ <h3 class="text-lg font-bold mb-6">Settings</h3> | |||
<summary class="collapse-title font-bold">Advanced config</summary> | |||
<div class="collapse-content"> | |||
<label class="form-control mb-2"> | |||
<!-- Samplers queue --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be inside "Other sampler settings"
The "advanced" is mostly for non-sampler stuff I think, like pinning slot number or stop sequence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw if you merge with latest upstream master branch, you can re-use the settings-modal-short-input
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can re-use the
settings-modal-short-input
component
Thanks, it works! However, the name is automatically set to samplers
, which is not very descriptive.
Should I modify settings-modal-short-input
to have a separate value for name? UPD: seems to work just fine. It would also allow setting prettier names for sampler parameters later.
Tested again, works correctly so far. The next (and probably the last) step is adding customization to chat templates: for example, suffix is quite useful in many cases as an additional guidance, and in some instances there might be interest in customizing default/chosen template (which, for example, is suggested my Mistral). This PR was initially supposed to be a list of cards to choose chat templates from, but I'm not sure it should be in UI - seems like it's only needed on server launch. |
In fact, I intentionally leave out chat template stuff because in the old UI, it's kinda hacky to support it via We could add the notion of |
* Samplers sequence: simplified and input field. * Removed unused function * Modify and use `settings-modal-short-input` * rename "name" --> "label" --------- Co-authored-by: Xuan Son Nguyen <son@huggingface.co>
This is a simple way to add samplers sequence into the new server UI - an input field with simplified sequence and an explanation for it. Since
server
doesn't support simplified version for now, I've added it too.