Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANN: Add Ascend CANN build ci #10217

Merged
merged 13 commits into from
Jan 24, 2025
Merged

CANN: Add Ascend CANN build ci #10217

merged 13 commits into from
Jan 24, 2025

Conversation

xuedinge233
Copy link
Contributor

No description provided.

@xuedinge233 xuedinge233 marked this pull request as draft November 8, 2024 09:42
@xuedinge233 xuedinge233 force-pushed the master branch 2 times, most recently from fc47d4f to 5ecac00 Compare November 8, 2024 10:21
@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 8, 2024
@hipudding hipudding added the Ascend NPU issues specific to Ascend NPUs label Nov 12, 2024
@hipudding hipudding changed the title ci: add Ascend CANN build CANN: add Ascend CANN build ci Nov 18, 2024
@hipudding hipudding changed the title CANN: add Ascend CANN build ci CANN: Add Ascend CANN build ci Nov 18, 2024
@xuedinge233 xuedinge233 marked this pull request as ready for review November 19, 2024 07:13
@hipudding hipudding self-requested a review November 19, 2024 11:24
Copy link
Collaborator

@hipudding hipudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need use correct cmake command.

Comment on lines 1399 to 1400
container:
image: ascendai/cann:openeuler-${{ matrix.cann }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only runs on openeuler?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first openeuler, and then ubuntu

@hipudding
Copy link
Collaborator

Please use x86 image for build test.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@hipudding
Copy link
Collaborator

I think it's better triggered by 'Ascend NPU' label, I don't want it block others' PR.

build: ['Release']
device: ['ascend910b3']
container:
image: ascendai/cann:${{ matrix.cann }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to format

.github/workflows/build.yml Outdated Show resolved Hide resolved
xuedinge233 and others added 2 commits January 22, 2025 10:25
Co-authored-by: Yuanhao Ji <jiyuanhao@apache.org>
@hipudding
Copy link
Collaborator

@slaren Could you please review this PR? Thanks. This PR add build check for Ascend NPU, Only enable when "Ascend NPU" label set.

@slaren slaren merged commit 466ea66 into ggerganov:master Jan 24, 2025
42 checks passed
anagri pushed a commit to BodhiSearch/llama.cpp that referenced this pull request Jan 26, 2025
* CANN: Add Ascend CANN build ci

* Update build.yml

* Modify cann image version

* Update build.yml

* Change to run on x86 system

* Update build.yml

* Update build.yml

* Modify format error

* Update build.yml

* Add 'Ascend NPU' label restrictions

* Exclude non PR event

Co-authored-by: Yuanhao Ji <jiyuanhao@apache.org>

* Update build.yml

---------

Co-authored-by: Yuanhao Ji <jiyuanhao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ascend NPU issues specific to Ascend NPUs devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants