Skip to content

Commit

Permalink
nix: clarify the meaning of "broken" and "badPlatforms"
Browse files Browse the repository at this point in the history
  • Loading branch information
SomeoneSerge committed Dec 25, 2023
1 parent 12115d6 commit ccdb89a
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions .devops/nix/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,15 @@ effectiveStdenv.mkDerivation (
};

meta = {
broken = (useCuda && effectiveStdenv.isDarwin) || (useMetalKit && !effectiveStdenv.isDarwin);
# Configurations we don't want even the CI to evaluate. Results in the
# "unsupported platform" messages. This is mostly a no-op, because
# cudaPackages would've refused to evaluate anyway.
badPlatforms = lib.optionals useCuda lib.platforms.darwin;

# Configurations that are known to result in build failures. Can be
# overridden by importing Nixpkgs with `allowBroken = true`.
broken = (useMetalKit && !effectiveStdenv.isDarwin);

description = "Inference of LLaMA model in pure C/C++${descriptionSuffix}";
homepage = "https://github.com/ggerganov/llama.cpp/";
license = lib.licenses.mit;
Expand All @@ -201,7 +209,8 @@ effectiveStdenv.mkDerivation (
SomeoneSerge
];

platforms = lib.platforms.unix;
# Extend `badPlatforms` instead
platforms = lib.platforms.all;
};
}
)

0 comments on commit ccdb89a

Please sign in to comment.