Skip to content

Commit

Permalink
mmap : fix fileno macro clash (#11076)
Browse files Browse the repository at this point in the history
* mmap : fix fileno macro clash

ggml-ci

* cont

ggml-ci
  • Loading branch information
ggerganov authored Jan 6, 2025
1 parent 727368c commit ae2f606
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions src/llama-mmap.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,16 @@ llama_file::~llama_file() = default;
size_t llama_file::tell() const { return pimpl->tell(); }
size_t llama_file::size() const { return pimpl->size; }

int llama_file::fileno() const {
int llama_file::file_id() const {
#ifdef _WIN32
return _fileno(pimpl->fp);
#else
#if defined(fileno)
return fileno(pimpl->fp);
#else
return ::fileno(pimpl->fp);
#endif
#endif
}

void llama_file::seek(size_t offset, int whence) const { pimpl->seek(offset, whence); }
Expand All @@ -265,7 +269,7 @@ struct llama_mmap::impl {

impl(struct llama_file * file, size_t prefetch, bool numa) {
size = file->size();
int fd = file->fileno();
int fd = file->file_id();
int flags = MAP_SHARED;
if (numa) { prefetch = 0; }
#ifdef __linux__
Expand Down Expand Up @@ -357,7 +361,7 @@ struct llama_mmap::impl {

size = file->size();

HANDLE hFile = (HANDLE) _get_osfhandle(file->fileno());
HANDLE hFile = (HANDLE) _get_osfhandle(file->file_id());

HANDLE hMapping = CreateFileMappingA(hFile, NULL, PAGE_READONLY, 0, 0, NULL);

Expand Down
2 changes: 1 addition & 1 deletion src/llama-mmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ struct llama_file {
size_t tell() const;
size_t size() const;

int fileno() const;
int file_id() const; // fileno overload

void seek(size_t offset, int whence) const;

Expand Down

0 comments on commit ae2f606

Please sign in to comment.