Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipliable dimarrays #58

Closed
wants to merge 60 commits into from
Closed

Multipliable dimarrays #58

wants to merge 60 commits into from

Conversation

ggebbie
Copy link
Owner

@ggebbie ggebbie commented Jun 27, 2024

This PR is incomplete and does not attempt to pass all tests. It is recommend to not merge until complete.

Features:

  • Inputs are streamlined by bundling all information with its central estimate and uncertainty. The Estimate type has this information and it is now used for solutions, first guesses, and observations.
  • Recommended for combine to replace solve with the idea that information from two Estimates is combined to make a new Estimate. solve previously required an underdetermined or overdetermined problem to be specified, but now there is limited logic to do this automatically.
  • Operations can be performed on arbitrary DimArrays using the MultipliableDimArrays.jl package.
  • Consistently uses DimArrays, including for coefficients
  • Rules for translating an arbitrary DimArray into an object for linear algebra operations using the DimArray{Number} for vectors and DimArray{DimArray} (i.e., nested types) for matrices
  • combine does not require the observational operation to be in linear or matrix form. It currently accepts a Function argument which makes a priori impulse reponse calculations unnecessary.
  • UnitfulMatrix wraps a DimArray in order to include units with the numerical values with this option that uses efficient storage of unit information

Future features:

  • Units will be included in an extension and are optional
  • Next step: go to multipliable-dimarrays branch and run/implement test_dimensional_data with units

@ggebbie ggebbie requested a review from b-r-hamilton June 27, 2024 20:35
@ggebbie ggebbie marked this pull request as draft June 29, 2024 01:51
@ggebbie
Copy link
Owner Author

ggebbie commented Nov 5, 2024

superceded by PR #59

@ggebbie ggebbie closed this Nov 5, 2024
@ggebbie ggebbie deleted the multipliable-dimarrays branch December 1, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant