Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Naga] replace unicode-xid with unicode-ident #7135

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Feb 14, 2025

Connections
Closes #7134.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@CrazyboyQCD CrazyboyQCD requested a review from a team as a code owner February 14, 2025 01:27
@CrazyboyQCD CrazyboyQCD changed the title perf: replace unicode-xid with unicode-ident [Naga]: replace unicode-xid with unicode-ident Feb 14, 2025
@CrazyboyQCD CrazyboyQCD changed the title [Naga]: replace unicode-xid with unicode-ident [Naga] replace unicode-xid with unicode-ident Feb 14, 2025
@ErichDonGubler ErichDonGubler self-assigned this Feb 15, 2025
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I checked that mozilla-central shouldn't have a problem consuming this; we use both unicode-xid and unicode-ident.

@ErichDonGubler ErichDonGubler merged commit a45e2db into gfx-rs:trunk Feb 15, 2025
34 checks passed
@ErichDonGubler
Copy link
Member

This caused me to file bug 1948441. 😀

@cwfitzgerald
Copy link
Member

Noice!

marcpabst pushed a commit to marcpabst/wgpu that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naga: replace unicode_xid with unicode_ident
3 participants