Unify Resolved*Descriptors into *Descriptors #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Feb 7, 2025
wgpu-core/src/binding_model.rs
Outdated
| <[BufferBinding<B>] as ToOwned>::Owned: std::fmt::Debug, | ||
| <[S] as ToOwned>::Owned: std::fmt::Debug, | ||
| <[TV] as ToOwned>::Owned: std::fmt::Debug, | ||
| [BindGroupEntry<'a, B, S, TV, T>]: ToOwned, |
There was a problem hiding this comment.
Thought: I wonder if it would be worthwhile (not in this PR) to roll our own Cow type without this bound, as we don't need it at all.
|
I think this is great opportunity for me to try jj for editing commits, because editing them in git is pain. |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
…scriptor` Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
…ptor` Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
cwfitzgerald
approved these changes
Feb 7, 2025
|
@sagudev this good to land? |
Yes. BTW jj did good, except for pushing where I fallback to git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Continuation of #7056, based on my idea from #5121 (comment)
Description
Generalize
Resolved*Descriptorsinto*Descriptorsusing generics. The only difference is id->Arc and some bounds mambo jumbo.All commits are standalone.
Testing
Fearless refactoring is provided by Rust.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.