Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target Specific Compilation #7076

Open
wants to merge 16 commits into
base: trunk
Choose a base branch
from
Open

Target Specific Compilation #7076

wants to merge 16 commits into from
+535 −157

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Feb 7, 2025 •
edited
Loading

Further attempt target specific stuff

Closes #7064
Closes #6949
Closes #3514

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner February 7, 2025 01:46
@cwfitzgerald cwfitzgerald marked this pull request as draft February 7, 2025 01:46
cwfitzgerald
cwfitzgerald commented Feb 7, 2025
View reviewed changes
wgpu/Cargo.toml Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald marked this pull request as ready for review February 9, 2025 22:19
nical
nical reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It looks worthy of a changelog entry.

@Wumpf Wumpf self-requested a review February 10, 2025 19:51
@cwfitzgerald cwfitzgerald mentioned this pull request Feb 11, 2025
Merged
6 tasks
@cwfitzgerald cwfitzgerald requested a review from nical February 11, 2025 01:21
@cwfitzgerald
Copy link
Member Author

Changelog added

Wumpf
Wumpf requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. that's it. I think you really figured it out! <3

Apart from the mostly doc oriented comments I left, there's some code here that you need to patch up now as part of this change

xtask/src/check_feature_dependencies.rs Show resolved Hide resolved
xtask/src/check_feature_dependencies.rs Show resolved Hide resolved
wgpu/Cargo.toml Outdated Show resolved Hide resolved
wgpu-hal/Cargo.toml Outdated Show resolved Hide resolved
wgpu-core/platform-features/windows-linux-android-emscripten/src/lib.rs Outdated Show resolved Hide resolved
wgpu-core/platform-features/windows-linux-android-emscripten/Cargo.toml Outdated Show resolved Hide resolved
wgpu-core/platform-features/windows-linux-android-emscripten/Cargo.toml Outdated Show resolved Hide resolved
wgpu-core/platform-features/wasm/Cargo.toml Outdated Show resolved Hide resolved
wgpu-core/Cargo.toml Outdated Show resolved Hide resolved
wgpu-core/Cargo.toml Show resolved Hide resolved
ErichDonGubler
ErichDonGubler reviewed Feb 11, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald requested a review from Wumpf February 18, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler left review comments

@nical nical Awaiting requested review from nical

@Wumpf Wumpf Awaiting requested review from Wumpf

Requested changes must be addressed to merge this pull request.

Assignees

@Wumpf Wumpf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a default feature for wgpu that enables Vulkan & GLES on Windows & Linux
4 participants
@cwfitzgerald @nical @ErichDonGubler @Wumpf