Remove additional trait impls from CommandBuffer
#6960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0de0b8b to
74aa7c6
Compare
|
I'll let @cwfitzgerald decide but Removing |
cwfitzgerald
requested changes
Jan 21, 2025
The only purpose of this type is to be given to `submit`. Remove `Clone` implementation and the inner `Arc<Mutex>`. From there, remove all comparison traits as two `CommandBuffer` ar always different.
74aa7c6 to
598ccfb
Compare
cwfitzgerald
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only purpose of this type is to be given to
submit. Being able to clone and share it has no value .Remove
Cloneimplementation and the innerArc<Mutex>. From there, remove all comparison traits as twoCommandBufferare always different.cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.