Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused enum variants #6550

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove unused enum variants #6550

merged 1 commit into from
Nov 15, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Nov 15, 2024

No description provided.

@teoxoy teoxoy requested a review from a team as a code owner November 15, 2024 10:19
@teoxoy teoxoy mentioned this pull request Nov 15, 2024
Draft
10 tasks
ErichDonGubler
ErichDonGubler approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to think how long it took you to figure this out, but this is awesome!

This might be worth a CHANGELOG entry, but I'm not sure. Error cases are always pretty detail-oriented, and there's noa lot of folks that deal directly with core. 🤔

@teoxoy
Copy link
Member Author

teoxoy commented Nov 15, 2024

It was quite fast actually, I replaced all pub enum with pub(crate) enum and ran cargo check -p wgpu-core.

@teoxoy
Copy link
Member Author

teoxoy commented Nov 15, 2024

I doubt anyone matches on these variants even if they are pub.

@teoxoy teoxoy merged commit 1abf3fe into gfx-rs:trunk Nov 15, 2024
27 checks passed
@teoxoy teoxoy deleted the rem-unused branch November 15, 2024 13:25
@teoxoy teoxoy mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @ErichDonGubler