-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate renderpass arc resolve & renderpass consume on end #5794
Conversation
I'll take on review for this. |
90fb38c
to
973201f
Compare
…ssCommand & consumes render pass upon end
973201f
to
0e85ae2
Compare
@ErichDonGubler bump? :) |
I got some more commits coming in that touch this code so I asked Erich if I can look at this PR to minimize fixing conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments about the new DrawKind
. Looks good otherwise!
great catch, thank you! |
307c84f
to
6ec5d34
Compare
Connections
RenderPass
make it difficult to use. #1453wgpu::ComputePass
) #5432Description
As before with ComputePass, we now convert all incoming
RenderCommand
first toArcRenderCommand
and then consume only those upon pass ending.Unlike with
ComputePass
, we already hadArcRenderCommand
around (because of render bundles), I "only" had to fill in the gaps here.Testing
Existing tests pass. Similar to how to compute passes, more are to come for the actual lifetime removal
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.