[wgpu] Remove unused ObjectId field of SubmissionIndex.
#5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e68e497 to
5510a85
Compare
|
I'm not sure about this PR at all. It seems like rustc or cargo are confused about something. |
Drop the first field of `wgpu::SubmissionIndex`, as it is unused. Adjust uses of the types' other field. Delete the `wgpu::context::Context` trait's `SubmissionIndex` associated type. Remove it from implementations. Drop the first field of the `Context` trait's `queue_submit` method's return value. Adjust implementations.
5510a85 to
db6d405
Compare
ErichDonGubler
approved these changes
Jun 10, 2024
|
IIRC, this also has something to do with the toolchain version? Not sure about the specifics, but I don't see a reason to keep an unused field around, in general. 🤷🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes warnings that field 0 of
SubmissionIndexis never used.I only see these warnings when referring to
wgpuvia apathdependency, not when fetching it fromcrates.io, and I don't really understand why. I wonder if this is related to rust-lang/cargo#8546.Drop the first field of
wgpu::SubmissionIndex, as it is unused. Adjust uses of the types' other field.Delete the
wgpu::context::Contexttrait'sSubmissionIndexassociated type. Remove it from implementations.Drop the first field of the
Contexttrait'squeue_submitmethod's return value. Adjust implementations.