Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hal doc] Document the main traits, and hal's validation approach #5566

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

jimblandy
Copy link
Member

  • Describe wgpu-hal's validation principles.

  • Describe wgpu-hal's main traits in the top-level docs.

  • Consistenly use wgpu-hal for the crate name.

@jimblandy jimblandy requested a review from a team as a code owner April 20, 2024 00:09
@jimblandy jimblandy force-pushed the hal-doc-traits-validation branch from e3dfd73 to 5634768 Compare April 20, 2024 00:09
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely agree on all fronts.

@Wumpf Wumpf self-requested a review April 24, 2024 15:54
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jimblandy jimblandy force-pushed the hal-doc-traits-validation branch from b2a702f to 55e7916 Compare April 24, 2024 21:22
@jimblandy jimblandy enabled auto-merge (rebase) April 24, 2024 21:23
@jimblandy jimblandy merged commit 253e65c into gfx-rs:trunk Apr 24, 2024
25 checks passed
@jimblandy jimblandy deleted the hal-doc-traits-validation branch April 26, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants