Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for storage texture access modes ReadOnly and ReadWrite on WebGPU backend #5434

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Add support for storage texture access modes ReadOnly and ReadWrite on WebGPU backend #5434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31f3f20
add support for all storage texture access modes
JolifantoBambla Mar 22, 2024
50616d9
Merge branch 'gfx-rs:trunk' into patch-1
JolifantoBambla Mar 25, 2024
8b93a42
update changelog
JolifantoBambla Mar 25, 2024
aff725f
fix typo
JolifantoBambla Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ Bottom level categories:

- Allow user to select which MSL version to use via `--metal-version` with Naga CLI. By @pcleavelin in [#5392](https://github.com/gfx-rs/wgpu/pull/5392)

#### WebGPU

- Add support for storage texture access modes `ReadOnly` and `ReadWrite`. By @JolifantoBambla in [#5434](https://github.com/gfx-rs/wgpu/pull/5434)

### Bug Fixes

#### General
Expand Down
4 changes: 2 additions & 2 deletions wgpu/src/backend/webgpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,10 +1578,10 @@ impl crate::context::Context for ContextWebGpu {
webgpu_sys::GpuStorageTextureAccess::WriteOnly
}
wgt::StorageTextureAccess::ReadOnly => {
panic!("ReadOnly is not available")
webgpu_sys::GpuStorageTextureAccess::ReadOnly
}
wgt::StorageTextureAccess::ReadWrite => {
panic!("ReadWrite is not available")
webgpu_sys::GpuStorageTextureAccess::ReadWrite
}
};
let mut storage_texture = webgpu_sys::GpuStorageTextureBindingLayout::new(
Expand Down
Loading