Code

Subgroup Operations#5301

Code

Merged

cwfitzgerald merged 89 commits intogfx-rs:trunkgfx-rs/wgpu:trunkfrom Lichtso:subgroup_featureCopy head branch name to clipboardApr 17, 2024

+3,328-70

Commits

Commits on Oct 25, 2023

• subgroup: Implement subgroupBallot for wgsl-in, wgsl-out, spv-out, hlsl-out

  Show description for 14f6be2
  exrook

  committed
  14f6be2

  Copy full SHA for 14f6be2

• subgroup: subgroupBallot metal out

  exrook

  committed
  e969f09

  Copy full SHA for e969f09

• subgroup: require GroupNonUnifomBallot capability

  exrook

  committed
  05feb88

  Copy full SHA for 05feb88

• subgroup: Add subgroup invocation id and subgroup size builtins

  exrook

  committed
  2ff8809

  Copy full SHA for 2ff8809

• subgroup: SubgroupInvocationId is only valid in compute stages

  exrook

  committed
  8cbf423

  Copy full SHA for 8cbf423

• subgroup: expierment with subgroupBarrier() based on OpControlbarrier

  Show description for 9430603
  exrook

  committed
  9430603

  Copy full SHA for 9430603

• subgroup: add statement for rest of subgroup ops

  exrook

  committed
  44f6929

  Copy full SHA for 44f6929

• subgroup: fix doc error on SubgroupBroadcast

  exrook

  committed
  b5be66e

  Copy full SHA for b5be66e

• subgroup: wgsl-in and spv-out for subgroup operations

  exrook

  committed
  a277ec5

  Copy full SHA for a277ec5

• subgroup: add optional predicate for subgroupBallot

  exrook

  committed
  dd49f99

  Copy full SHA for dd49f99

• Renames SubgroupBroadcast => SubgroupGather and BroadcastMode => GatherMode.

  

  Lichtso

  authored and

  exrook

  committed
  18ceb01

  Copy full SHA for 18ceb01

• General fixes.

  

  Lichtso

  authored and

  exrook

  committed
  7c911ba

  Copy full SHA for 7c911ba

• Adds BuiltIn::NumSubgroups, BuiltIn::SubgroupId.

  

  Lichtso

  authored and

  exrook

  committed
  f5c4ad7

  Copy full SHA for f5c4ad7

• Adds GatherMode::Shuffle, GatherMode::ShuffleDown, GatherMode::ShuffleUp, GatherMode::ShuffleXor.

  

  Lichtso

  authored and

  exrook

  committed
  f931a47

  Copy full SHA for f931a47

• Implements all frontends and backends.

  

  Lichtso

  authored and

  exrook

  committed
  d8e17e7

  Copy full SHA for d8e17e7

• Adjusts metal backend test_stack_size().

  

  Lichtso

  authored and

  exrook

  committed
  43133d0

  Copy full SHA for 43133d0

• Adds test and snapshots.

  

  Lichtso

  authored and

  exrook

  committed
  275a5a5

  Copy full SHA for 275a5a5

• subgroup: fix spv-in

  exrook

  committed
  f04b71d

  Copy full SHA for f04b71d

• subgroup: Add 0 arg subgroupBallot to tests and fix wgsl-out whitespace

  exrook

  committed
  7a5bf0f

  Copy full SHA for 7a5bf0f

• subgroup: Add spv-in test

  exrook

  committed
  2aaf0a0

  Copy full SHA for 2aaf0a0

• subgroup: resolve fixmes & fix typo

  exrook

  committed
  fb1e3f9

  Copy full SHA for fb1e3f9

• subgroup: Add subgroup capability

  exrook

  committed
  209225a

  Copy full SHA for 209225a

• subgroup: Treat subgroup operation results as non-uniform

  exrook

  committed
  77d33b9

  Copy full SHA for 77d33b9

• subgroup: refactor wgsl subgroup gather parsing

  exrook

  committed
  1e51650

  Copy full SHA for 1e51650

• subgroup: doc comments for subgroup Statements and Expressions

  exrook

  committed
  68fc4d5

  Copy full SHA for 68fc4d5

• subgroup: add validation for each subgroup operation type

  Show description for 91c569d
  exrook

  committed
  91c569d

  Copy full SHA for 91c569d

• Add feature for subgroup operations in fragment and compute shaders

  exrook

  committed
  6f6f789

  Copy full SHA for 6f6f789

• Adds feature detection for Vulkan.

  exrook

  committed
  7d2e273

  Copy full SHA for 7d2e273

• Adds feature detection for Metal.

  

  Lichtso

  authored and

  exrook

  committed
  55e21e8

  Copy full SHA for 55e21e8

• Adds feature detection for DirectX 12.

  

  Lichtso

  authored and

  exrook

  committed
  2e44fb1

  Copy full SHA for 2e44fb1

• Adds subgroup_operations tests.

  

  Lichtso

  authored and

  exrook

  committed
  e186d0e

  Copy full SHA for e186d0e

• Pass subgroup capability to naga

  exrook

  committed
  9c12f08

  Copy full SHA for 9c12f08

• Separate subgroup feature into one flag per shader stage

  exrook

  committed
  358c2a7

  Copy full SHA for 358c2a7

Commits on Oct 26, 2023

• Merge branch 'trunk' into subgroup_feature

  cwfitzgerald

  authored
  9afec48

  Copy full SHA for 9afec48

• Merge branch 'trunk' into subgroup_feature

  cwfitzgerald

  authored
  edd11d1

  Copy full SHA for edd11d1

Commits on Oct 28, 2023

• Merge branch 'trunk' into subgroup_feature

  cwfitzgerald

  authored
  c821cc9

  Copy full SHA for c821cc9

• Fix compiles

  cwfitzgerald

  committed
  ebaf08d

  Copy full SHA for ebaf08d

Commits on Nov 1, 2023

• subgroups: DX12 doesn't support subgroup ops in vertex stage

  exrook

  committed
  afaf441

  Copy full SHA for afaf441

• Merge branch 'trunk' into subgroup_feature

  exrook

  committed
  fd14a43

  Copy full SHA for fd14a43

Commits on Nov 5, 2023

• subgroup: fix hlsl subgroup_id

  exrook

  committed
  7e0060e

  Copy full SHA for 7e0060e

• subgroups: update naga snapshots

  exrook

  committed
  d822524

  Copy full SHA for d822524

• Merge branch 'trunk' into subgroup_feature

  exrook

  committed
  a86a130

  Copy full SHA for a86a130

Commits on Nov 6, 2023

• subgroups: fix gpu test on systems with subgroup size of 1

  exrook

  committed
  011016f

  Copy full SHA for 011016f

Commits on Nov 7, 2023

• subgroup: emit Shuffle instead of Broadcast on spv-out

  exrook

  committed
  a68ef32

  Copy full SHA for a68ef32

Commits on Nov 16, 2023

• subgroup: Use bitmask to track pass/failed tests

  exrook

  committed
  3bc4aa9

  Copy full SHA for 3bc4aa9

Commits on Nov 21, 2023

• subgroups: Print detailed error message on test failure

  exrook

  committed
  8420c97

  Copy full SHA for 8420c97

• subgroups: Add tests in divergent control flow

  exrook

  committed
  395cd21

  Copy full SHA for 395cd21

• subgroups: correct changelog entry PR link

  exrook

  committed
  f1a4d75

  Copy full SHA for f1a4d75

Commits on Nov 22, 2023

• Merge branch 'trunk' into subgroup_feature

  exrook

  committed
  4dd8e06

  Copy full SHA for 4dd8e06

Commits on Nov 28, 2023

• Merge branch 'trunk' into HEAD

  exrook

  committed
  50355e0

  Copy full SHA for 50355e0

• subgroups: Expect test failures on metal

  exrook

  committed
  4bf0479

  Copy full SHA for 4bf0479

• subgroups: Add test for divergent for loop

  exrook

  committed
  156f026

  Copy full SHA for 156f026

• subgroups: Verify convergence after finishing other tests

  exrook

  committed
  f9fc7f0

  Copy full SHA for f9fc7f0

Commits on Feb 24, 2024

• Merge trunk into subgroup_feature

  Lichtso

  committed
  8346dea

  Copy full SHA for 8346dea

• Fixes "cargo xtask validate wgsl".

  Lichtso

  committed
  1684dd7

  Copy full SHA for 1684dd7

• Fixes typo.

  Lichtso

  committed
  97de312

  Copy full SHA for 97de312

• Adjusts expected failure on the Metal backend.

  Lichtso

  committed
  5d868e9

  Copy full SHA for 5d868e9

Commits on Mar 21, 2024

• Merge official/trunk into subgroup_feature

  Lichtso

  committed
  35a6ec7

  Copy full SHA for 35a6ec7

• Adds utility add_result_to_mask() in WGSL test

  Lichtso

  committed
  dd70129

  Copy full SHA for dd70129

• Fixes platform feature detection

  Lichtso

  committed
  0034e25

  Copy full SHA for 0034e25

• Unifies SUBGROUP_COMPUTE and SUBGROUP_FRAGMENT into SUBGROUP

  Lichtso

  committed
  97cdd51

  Copy full SHA for 97cdd51

• Adds documentation for enum GatherMode

  Lichtso

  committed
  2feeccb

  Copy full SHA for 2feeccb

• Removes #[repr(u8)] from CollectiveOperation

  Lichtso

  committed
  040963e

  Copy full SHA for 040963e

• Removes Prefix from subgroup Exclusive/Inclusive Add/Mul

  Lichtso

  committed
  555fb04

  Copy full SHA for 555fb04

• Renames validate_subgroup_broadcast() => validate_subgroup_gather()

  Lichtso

  committed
  b41881c

  Copy full SHA for b41881c

• Disallows reductions with boolean operands in validate_subgroup_operation()

  Lichtso

  committed
  33986f9

  Copy full SHA for 33986f9

• Checks for CollectiveOperation in validate_subgroup_operation()

  Lichtso

  committed
  d610925

  Copy full SHA for d610925

• Uses SV_GroupIndex to emulate SubgroupId in HLSL backend

  Lichtso

  committed
  8543344

  Copy full SHA for 8543344

• Adds argument of InclusiveScan to need_bake_expressions in HLSL backend

  Lichtso

  committed
  43b664c

  Copy full SHA for 43b664c

Commits on Mar 22, 2024

• Adds support for entrypoint built-in bindings in structures.

  Lichtso

  committed
  09ba376

  Copy full SHA for 09ba376

Commits on Apr 4, 2024

• Adds requested comments

  Lichtso

  committed
  dae411d

  Copy full SHA for dae411d

• Removes arg_num in HLSL writer

  Lichtso

  committed
  eb8d274

  Copy full SHA for eb8d274

• Moves __local_invocation_index into write_interface_struct()

  Lichtso

  committed
  cfb92fb

  Copy full SHA for cfb92fb

• Adds SUBGROUP_BARRIER feature and capability

  Lichtso

  committed
  a3a3012

  Copy full SHA for a3a3012

• Merge trunk into subgroup_feature

  Lichtso

  committed
  4ea5395

  Copy full SHA for 4ea5395

• unimplemented => unreachable

  Lichtso

  committed
  db3f5e5

  Copy full SHA for db3f5e5

• Uses members instead of func.arguments

  Lichtso

  committed
  48d46b7

  Copy full SHA for 48d46b7

Commits on Apr 5, 2024

• Adds test for subgroup size consistency

  Lichtso

  committed
  1629691

  Copy full SHA for 1629691

• Uses util::DownloadBuffer in test

  Lichtso

  committed
  1b45829

  Copy full SHA for 1b45829

• Merge trunk into subgroup_feature

  Lichtso

  committed
  2513b6d

  Copy full SHA for 2513b6d

• Fixes merge conflicts

  Lichtso

  committed
  0a94660

  Copy full SHA for 0a94660

• Fixes __local_invocation_id in HLSL writer

  Lichtso

  committed
  882ee3d

  Copy full SHA for 882ee3d

Commits on Apr 8, 2024

• Adds missing mode in Statement::SubgroupGather

  Lichtso

  committed
  158b832

  Copy full SHA for 158b832

Commits on Apr 9, 2024

• Adds VK_EXT_subgroup_size_control and VK_PIPELINE_SHADER_STAGE_CREATE_ALLOW_VARYING_SUBGROUP_SIZE_BIT_EXT.

  Lichtso

  committed
  96649e6

  Copy full SHA for 96649e6

• Adds min_subgroup_size and max_subgroup_size device limits.

  Lichtso

  committed
  98df726

  Copy full SHA for 98df726

• Adds EntryPointError::InvalidMultiDimensionalSubgroupBuiltIn

  Lichtso

  committed
  271297c

  Copy full SHA for 271297c

Commits on Apr 15, 2024

• Moves EntryPointError::InvalidMultiDimensionalSubgroupBuiltIn => VaryingError::InvalidMultiDimensionalSubgroupBuiltIn.

  Lichtso

  committed
  b66bfeb

  Copy full SHA for b66bfeb

• Merge official/trunk into subgroup_feature

  Lichtso

  committed
  22d30c3

  Copy full SHA for 22d30c3

• Fix after merge.

  

  atlv24

  authored and

  Lichtso

  committed
  41ec41b

  Copy full SHA for 41ec41b