fix(const_eval): use component count, not arg. count, for component-wise iter. #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
teoxoy
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Fixes a regression/bug introduced by #4879 (sorry!). 😅
Description
Describe what problem this is solving, and how it's solved.
Previously, the arg. count was being used for iterating over component groups, but the count of components should have been used instead. This PR fixes that.
Testing
Explain how this change is tested.
It's a bug-fix, so I consider it tested! I would be open to a request for more coverage in addition to this.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toI don't consider this necessar, since Impl. more component-wise built-ins in const. eval. #4879 hasn't shipped yet, but I can do it if requested.CHANGELOG.md. See simple instructions inside file.