Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Surface API #3236

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Nov 26, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

First step of #2869.

Description

Cleans up the current surface capabilities interface so that extension is easier. Commits are standalone and should be rebased.

Testing
Ran the examples.

@cwfitzgerald cwfitzgerald changed the title Unify Surface Capabilities APIs under one function call Cleanup Surface API Nov 26, 2022
@cwfitzgerald cwfitzgerald force-pushed the unify-surface-capabilities branch from 114f8e4 to 5d2035b Compare November 26, 2022 03:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #3236 (5d2035b) into master (d4b1d57) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3236      +/-   ##
==========================================
+ Coverage   64.64%   64.74%   +0.10%     
==========================================
  Files          82       82              
  Lines       39501    39436      -65     
==========================================
- Hits        25534    25533       -1     
+ Misses      13967    13903      -64     
Impacted Files Coverage Δ
wgpu-core/src/device/mod.rs 66.64% <0.00%> (+0.31%) ⬆️
wgpu-core/src/instance.rs 65.92% <0.00%> (+2.13%) ⬆️
wgpu-types/src/lib.rs 87.51% <0.00%> (-0.42%) ⬇️
wgpu/src/backend/direct.rs 55.40% <0.00%> (+0.59%) ⬆️
wgpu/src/lib.rs 50.55% <0.00%> (+0.22%) ⬆️
wgpu-core/src/hub.rs 60.67% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald cwfitzgerald merged commit 183ba3f into gfx-rs:master Nov 27, 2022
@cwfitzgerald cwfitzgerald deleted the unify-surface-capabilities branch November 27, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants