(WIP) Add tests for empty buffers and map ranges #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poke - the PR body mentions this still needs more follow up? |
|
Yeah IIRC wgpu right now doesn't allow me to express some of the zero sizes (due to a bunch of NonZeroU32 parameters where the WebGPU spec has regular integers). I probably need to write the test on top of wgpu-core instead |
|
Cool, merging then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
There are a couple of fixes related to zero-sized buffers in #2877,
Description
This PR adds some tests to verify the fixes in #2877.
The tests aren't quite ready to land because creating a zero-sized buffer slice currently panics, I'm trying to figure out why that is.
The assertion was added in 2bc930d
Testing
This PR is all about testing.