Add multithreaded_compute test #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
May 8, 2019
|
Had to reduce the thread count to 8. |
bors bot
added a commit
that referenced
this pull request
May 9, 2019
157: Add multithreaded_compute test r=kvark a=rukai As requested in #152 I have opened a PR to add the repro as a test case. I used [rusty fork](https://github.com/AltSysrq/rusty-fork) to allow setting a timeout. Rusty fork also runs each test in a separate process. Open to any suggestions on how to organize tests etc. I could add #156 if you want? Maybe name the tests by issue number? If we add a test for every issue, breaking changes would become really annoying :/ Co-authored-by: Rukai <rubickent@gmail.com>
Build succeeded |
mitchmindtree
pushed a commit
to mitchmindtree/wgpu
that referenced
this pull request
Feb 23, 2020
157: Handle resizing in hello-triangle r=kvark a=quadrupleslap Nothing gets drawn on my computer unless the swap chain is resized along with the window. ``` $ uname -a Linux red 5.3.7-arch1-1-ARCH gfx-rs#1 SMP PREEMPT Fri Oct 18 00:17:03 UTC 2019 x86_64 GNU/Linux $ wmctrl -m Name: bspwm Class: wm PID: 665 Window manager's "showing the desktop" mode: N/A ``` Co-authored-by: Ram Kaniyur <quadrupleslap@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
157: Handle resizing in hello-triangle r=kvark a=quadrupleslap Nothing gets drawn on my computer unless the swap chain is resized along with the window. ``` $ uname -a Linux red 5.3.7-arch1-1-ARCH #1 SMP PREEMPT Fri Oct 18 00:17:03 UTC 2019 x86_64 GNU/Linux $ wmctrl -m Name: bspwm Class: wm PID: 665 Window manager's "showing the desktop" mode: N/A ``` Co-authored-by: Ram Kaniyur <quadrupleslap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #152 I have opened a PR to add the repro as a test case.
I used rusty fork to allow setting a timeout.
Rusty fork also runs each test in a separate process.
Open to any suggestions on how to organize tests etc.
I could add #156 if you want?
Maybe name the tests by issue number?
If we add a test for every issue, breaking changes would become really annoying :/