Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[spv-out] Handle break and continue in switch statements. #1304

Merged
merged 1 commit into from
Aug 27, 2021
Merged

[spv-out] Handle break and continue in switch statements. #1304

merged 1 commit into from
Aug 27, 2021

Conversation

jimblandy
Copy link
Member

Fixes #1030.
Fixes #1017.

JCapucho
JCapucho approved these changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very straightforward change

@jimblandy jimblandy merged commit cb0ad25 into gfx-rs:master Aug 27, 2021
@jimblandy jimblandy deleted the switch-break-continue branch August 27, 2021 23:40
This was referenced Aug 28, 2021
Merged
Closed
@kvark kvark added the can backport PR that can be back-ported to a release branch label Aug 29, 2021
@kvark kvark mentioned this pull request Sep 1, 2021
Merged
@kvark
Copy link
Member

kvark commented Sep 1, 2021

Published in 0.6.2

@kvark kvark removed the can backport PR that can be back-ported to a release branch label Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JCapucho JCapucho JCapucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Naga does not accept switch statement Naga panics translating valid WGSL to SPIR-V
3 participants
@jimblandy @kvark @JCapucho