Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mtl] add explicit return types for msg_send! calls #2943

Merged
merged 1 commit into from Aug 7, 2019
Merged

[mtl] add explicit return types for msg_send! calls #2943

merged 1 commit into from Aug 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2019

Fixes #2939
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends: mtl
  • rustfmt run on changed code

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sweet!
I wish there was a way to produce the error in compile time if we miss anything.
bors r+

bors bot added a commit that referenced this pull request Aug 7, 2019
2943: [mtl] add explicit return types for `msg_send!` calls r=kvark a=aleksijuvani

Fixes #2939
PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: mtl
- [ ] `rustfmt` run on changed code

Co-authored-by: Aleksi Juvani <aleksi@aleksijuvani.com>
@bors
Copy link
Contributor

bors bot commented Aug 7, 2019

Build succeeded

@bors bors bot merged commit 15df872 into gfx-rs:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msg_send without explicit return types will break if/when ! is stabilized.
2 participants