Bump cocoa version. #1074
Merged
Bump cocoa version. #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
1074: Implement ETC2 and ASTC textures r=kvark a=cwfitzgerald **Connections** Closes gfx-rs#1070. Makes progress towards gfx-rs#1069. **Description** This PR has multiple functions: - Adds ETC and ASTC compressed textures behind features. - Adds three helper functions on `Extent3d` that help in calculating mip sizes: `at_mip_level`, `max_mips`, and `physical_size`. - Refactors various conversions into a public `TextureFormat::describe` function. I have used a decl macro to ease in the declaration and modifcation of an otherwise horribly verbose function. I have tried to use clever multi-select based data copying to reduce the possibility for errors, but there's a _lot_ of data moving around here. **Testing** Upcoming wgpu-rs pr adding wider compressed texture support to the skybox example. Helper functions were tested with doctests. Marked as draft until I can get the wgpu-rs pr done and prove it works, it is, however, ready for review. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.