Improve docs header style #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causes a lot of lag and also probably isn't the best to inline since we have scss preprocessing
Keats
reviewed
Jun 11, 2024
| <script type="text/javascript" src="{{ get_url(path="elasticlunr.min.js") }}"></script> | ||
| <script type="text/javascript" src="{{ get_url(path="search.js") }}"></script> | ||
| <script type="text/javascript" src="{{ get_url(path='elasticlunr.min.js') }}"></script> | ||
| <script type="text/javascript" src="{{ get_url(path='search.js') }}"></script> |
There was a problem hiding this comment.
I prefer " to ', any reasons to change those?
There was a problem hiding this comment.
If the editor lsp or formatter is set to regular HTML, it can get hung up on the fact that there are double quotes inside the strings and refuses to work. My reason for this case was that in JS you can use single quotes in double quotes and vice versa, so they should likely be the same in HTML.
I believe the specific reason in this case was that I was using Prettier which was angry that the tags weren't closed due to some weirdness there.
There was a problem hiding this comment.
good point i didn't think of that
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
* refactor: pattern to separate file causes a lot of lag and also probably isn't the best to inline since we have scss preprocessing * fix: escape quotes properly * feat: improve header styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
The current website style for the header is a bit jank and leaves a bit to be desired. The search bar and navigation are both left aligned which makes it feel a bit cluttered, though that's not too bad of an issue. The real issue I had with it was how the mobile styles looked. The spacing method causes the links to be shifted left a bit and the search bar to sit right against the text.
Before
Desktop styles
Mobile styles
After
Desktop styles
Mobile styles
Additional Information
A lot of the jank comes from how the nav was previously just using inline-block and margin-right based styles.
Also, there was a random
.containerstyle applied to only the home page's header which was reused on the contents of the body as well which made restyling a pain. I have made the decision to remove it from the header section entirely for consistency between the home and docs pages.There are also a lot of other evil styles such as the
.selling-pointstyles in general, though that would be more of a style rewrite which is more opinionated and likely better saved for a full website rewrite.