Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no response from the server,
load_data
would panic with:response status
.This patch removes the
expect
in favor of an error message that we couldn't get a response from the server for a given url.Before:
After:
Following up, I started thinking about it would be great if the function called in the templates would -- by default -- have messages that told you that they failed. I'm playing around with automatically wrapping all the registered Terra functions with messages/context using Error::chain so that the above response would look more like:
Are you interested in a PR for this?