Make path to config.toml independent from root dir #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
May 13, 2020
| @@ -62,9 +62,10 @@ impl<'a> SerializedTaxonomyItem<'a> { | |||
| impl Site { | |||
| /// Parse a site at the given path. Defaults to the current dir | |||
| /// Passing in a path is used in tests and when --root argument is passed | |||
| pub fn new<P: AsRef<Path>>(path: P, config_file: &str) -> Result<Site> { | |||
| pub fn new<P: AsRef<Path>, P2: AsRef<Path>>(path: P, config_file: P2) -> Result<Site> { | |||
There was a problem hiding this comment.
I think you can reuse P no?
There was a problem hiding this comment.
It would force path and config_file to have the same type, what isn't necessarily required here. One may want to use for example &PathBuf and &str
But yes, currently this function is always called with &PathBuf so it doesn't matter that much + makes this line quite long.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1022
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one:Have you created/updated the relevant documentation page(s)?