Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap httr out for httr2 #48

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Swap httr out for httr2 #48

merged 7 commits into from
Aug 19, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Aug 13, 2024

Description

Removed the http client httr and now are using httr2 throughout the package.

Reason for this is that httr has entered a stage where they're not really working on the package anymore, and shifting focus to httr2. Had to wait a bit to do this until webmockr and vcr supported httr2 (only used in tests, but still important)

Related Issue

fixes #21

Example

run any fxn in the package ...

Testing

  • Tests in this package are passing locally and on CI
  • Ran the proof shiny app with this package and it works smoothly

@sckott sckott requested a review from seankross August 13, 2024 17:34
@sckott sckott added this to the rcromwell v3.2.6 milestone Aug 13, 2024
Copy link

@seankross seankross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, two questions above. Thanks for this, looks cool!

@seankross seankross self-requested a review August 19, 2024 20:21
@sckott sckott changed the base branch from main to dev August 19, 2024 21:27
@sckott sckott merged commit 1be2034 into dev Aug 19, 2024
6 checks passed
@sckott sckott deleted the httr2-vcr-webmockr branch August 19, 2024 21:33
@tefirman tefirman mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httr -> httr2
2 participants