Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store CROMWELLURL not as an env var #29

Closed
sckott opened this issue Feb 2, 2024 · 1 comment · Fixed by #31
Closed

Store CROMWELLURL not as an env var #29

sckott opened this issue Feb 2, 2024 · 1 comment · Fixed by #31
Labels
shiny related to use within a shiny app
Milestone

Comments

@sckott
Copy link
Member

sckott commented Feb 2, 2024

So i'm nearly certain now env vars are global across users of the shiny cromwell app, so the URL here needs to be set using a different method.

And while we're at it support more than one server cause folks may have that use case. I don't want to go back to passing a url as a param, but may have to. If that's the route then use a function as the default? e.g,

cromwell_jobs <- function(..., url = find_url()) {
    ...
}

# where find_url is
find_url <- function(url = NULL) {
    # look in an internal package env
}
@sckott sckott added the shiny related to use within a shiny app label Feb 2, 2024
@sckott sckott added this to the v3.2 milestone Feb 2, 2024
@sckott
Copy link
Member Author

sckott commented Feb 3, 2024

plus Token handling too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shiny related to use within a shiny app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant