New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single line hash comments support on BigQuery. #26

Merged

zdenal merged 1 commit into main from zdenko/syn-2812-parse-error-not-handled-as-bigquery-line-comment

Feb 22, 2024

zdenal commented Feb 22, 2024 •

edited

Loading

Why

Single line hash comment on BQ are raising a parsing error like ['SQL parser failed: Expected end of statement, found: #']
for snippets like

...
    USING (account_id)

# ROW_NUMBER() is just so we can filter on action type :D
QUALIFY action_type IS NOT NULL

This PR is solving it.


          Single line hash comments support on BigQuery.

4fc55dc

zdenal requested a review from lustefaniak

February 22, 2024 13:55

lustefaniak approved these changes

View reviewed changes

zdenal merged commit 04fa553 into main

2 checks passed

lustefaniak deleted the zdenko/syn-2812-parse-error-not-handled-as-bigquery-line-comment branch

February 22, 2024 14:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet