-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename APM tracking feature flags to tracing #74
Comments
That has to be aligned with Flutter and RN since we init the iOS SDK with the options |
@romtsn, @markushi, @mattjohnsonpint, please accomplish the small task as requested by me above
|
We already changed the names for Cocoa with getsentry/sentry-cocoa#2417. The change is going to be in 8.0.0. Any reason not to align with that, @marandaneto? |
I just checked Java/Android, looking good already. For
Manifest metdata options
AGP
|
I guess the biggest problem is only when we have a single configuration for multiple features, such as |
Dart has We can rename We can get rid of Maybe we can rename |
We don't have a flag for that.
I agree. |
The only ones we have in .NET are directly related to the iOS options that changed. (ie., The only other usage of "tracking" is with |
@marandaneto seems like this is completed, can you please verify? |
All tasks are done; so we can close this. Please reopen otherwise. |
Please validate that your SDK doesn't contain performance feature flags named
...tracking...
.If it does, please mark them as deprecated and add a new one named
...tracing...
. Other features not related to performance can keep the name...tracking...
. If a feature flag is related to performance and something else, keeping the name...tracking...
is OK. Please update your user facing docs accordingly.Example from the Cocoa SDK:
enableAutoPerformanceTracking
turns intoenableAutoPerformanceTracing
enableFileIOTracking
becomesenableFileIOTracing
enableAutoSessionTracking
stays the same as not related to performanceenableNetworkTracking
stays the same as related to performance and breadcrumbsIf your SDK needs changes, please create an issue. If not, mark the task as done:
Tasks
The text was updated successfully, but these errors were encountered: