ref(metrics): Change metrics topic name #2089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2089 +/- ##
==========================================
- Coverage 91.11% 91.04% -0.07%
==========================================
Files 510 510
Lines 22346 22346
==========================================
- Hits 20361 20346 -15
- Misses 1985 2000 +15
Continue to review full report at Codecov.
|
|
Does this PR depend on the Sentry one first or are they independent?
|
We should add LogAppendTime as suggested by Lyn
@lynnagara They can be independent since using this topic requires manually running the consumer in sentry (that ultimately produces to the I believe we will want subscriptions on it, how do I create it with LogAppendTime? |
e97062c to
f6fb899
Compare
| config = {Topic.EVENTS: {"message.timestamp.type": "LogAppendTime"}} | ||
| config = { | ||
| Topic.EVENTS: {"message.timestamp.type": "LogAppendTime"}, | ||
| Topic.METRICS: {"message.timestamp.type": "LogAppendTime"}, |
There was a problem hiding this comment.
@lynnagara was this all I needed?
There was a problem hiding this comment.
Yes, thanks. Has this topic already being created in production? If yes we should make sure it has this configuration, if no we need to create it with this configuration.
There was a problem hiding this comment.
Has this topic already being created in production?
not to my knowledge, is this something we can open a PR for? or is it a request to ops?
There was a problem hiding this comment.
You can wait till when we will run the consumer in prod. Anyway there is no Clickhouse storage. Let's get everything working properly in dev first
afcc06a to
64fe3d4
Compare
4caae1d to
c81c3ca
Compare
c81c3ca to
387f256
Compare
getsentry/sentry#28431 Adds a consumer for the
ingest-metricstopic that then translates the raw metrics data of strings for all the metric names, tag keys and tag values to integers. The translated messages will go in thesnuba-metricstopic so that ClickHouse can store the metrics data.