Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(workflow_engine): Update the DataConditionHandler.*Type #85610

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

saponifi3d
Copy link
Contributor

Description

Update the data condition handler type to allow for it to exist in multiple areas - this will be used for a couple of the generic handlers.

Since each type would need to change took the opportunity to namespace the type instead.

…ta condition to be usable in a action filter or workflow trigger
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/workflow_engine/processors/delayed_workflow.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #85610       +/-   ##
===========================================
+ Coverage   42.27%   87.90%   +45.63%     
===========================================
  Files        9627     9661       +34     
  Lines      544874   546744     +1870     
  Branches    21271    21271               
===========================================
+ Hits       230329   480607   +250278     
+ Misses     314237    65829   -248408     
  Partials      308      308               

@saponifi3d saponifi3d force-pushed the jcallender/aci/detector-issue-resolve branch from 45d99e0 to 4a2d307 Compare February 21, 2025 02:26
@saponifi3d saponifi3d marked this pull request as ready for review February 21, 2025 02:33
@saponifi3d saponifi3d requested a review from a team as a code owner February 21, 2025 02:33
# Description
Create Condition Handler for workflow trigger for "When an issue is
resolved"
@saponifi3d saponifi3d enabled auto-merge (squash) February 21, 2025 16:34
@saponifi3d saponifi3d merged commit 1435ad0 into master Feb 21, 2025
49 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci/detector-issue-resolve branch February 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants