Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-details): Remove extra ' in fold section key #85607

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Feb 20, 2025

fixes a typo by checking if that wrong key is being used and if it is, updating it to have the correct key

@roggenkemper roggenkemper marked this pull request as ready for review February 20, 2025 23:37
@roggenkemper roggenkemper requested a review from a team as a code owner February 20, 2025 23:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #85607      +/-   ##
==========================================
- Coverage   87.89%   87.89%   -0.01%     
==========================================
  Files        9668     9668              
  Lines      546742   546741       -1     
  Branches    21291    21291              
==========================================
- Hits       480569   480568       -1     
  Misses      65866    65866              
  Partials      307      307              

Copy link
Member

@MichaelSun48 MichaelSun48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day in 2030 this code is going to be gone and some user will be very confused

Copy link
Member

@mrduncan mrduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add a comment to this to describe why this is necessary to help future-us

Copy link

codecov bot commented Feb 21, 2025

Bundle Report

Changes will increase total bundle size by 152.23kB (0.46%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.2MB 152.23kB (0.46%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/vendors-node_modules_emotion_styled_dist_emotion-styled_browser_esm_js-node_modules_color_ind-1ca72f.*.js (New) 1.56MB 1.56MB 100.0% 🚀
chunks/app_bootstrap_initializeApp_tsx-app_components_avatar_actorAvatar_tsx-app_components_avatar_a-7c38cc.*.js 4.87kB 1.43MB 0.34%
chunks/app_components_assigneeBadge_tsx-app_components_badge_featureBadge_tsx-app_components_charts_-643f8b.*.js 308 bytes 1.13MB 0.03%
chunks/vendors-node_modules_emotion_react_jsx-runtime_dist_emotion-react-jsx-runtime_browser_esm_js--094051.*.js (New) 959.66kB 959.66kB 100.0% 🚀
chunks/vendors-node_modules_base64-arraybuffer_dist_base64-arraybuffer_es5_js-node_modules_classname-ba8cb1.*.js 3.18kB 652.39kB 0.49%
chunks/app_actionCreators_redirectToProject_tsx-app_bootstrap_commonInitialization_tsx-app_bootstrap-f231df.*.js (New) 435.15kB 435.15kB 100.0% 🚀
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js 185 bytes 365.96kB 0.05%
chunks/app_actionCreators_preferences_tsx-app_components_avatar_actorAvatar_tsx-app_components_chevr-594660.*.js -235 bytes 324.22kB -0.07%
chunks/vendors-node_modules_classnames_index_js-node_modules_lodash_debounce_js-node_modules_lodash_-0bc2e8.*.js (New) 307.71kB 307.71kB 100.0% 🚀
chunks/app_utils_discover_discoverQuery_tsx-app_views_dashboards_dashboard_tsx-app_views_dashboards_-cbfeaf.*.js 406 bytes 289.92kB 0.14%
chunks/app_components_events_eventEntries_tsx.*.js 25 bytes 251.69kB 0.01%
chunks/app_views_issueDetails_groupDetails_tsx.*.js 113 bytes 172.11kB 0.07%
chunks/app_actionCreators_members_tsx-app_components_acl_access_tsx-app_components_avatar_avatarList-1442c2.*.js 55 bytes 164.49kB 0.03%
chunks/vendors-node_modules_sentry-internal_rrweb_dist_rrweb_js.*.js (New) 148.91kB 148.91kB 100.0% 🚀
chunks/app_views_traces_content_tsx-node_modules_core-js_modules_es_array_to-spliced_js.*.js 1.97kB 121.71kB 1.65%
chunks/vendors-node_modules_sentry-internal_rrweb-player_dist_rrweb-player_js.*.js (New) 114.08kB 114.08kB 100.0% 🚀
chunks/app_data_timezones_tsx-app_utils_useUserTeams_tsx-app_views_alerts_builder_builderBreadCrumbs-5a6e11.*.js 1.1kB 111.88kB 1.0%
chunks/app_components_events_interfaces_crashContent_stackTrace_rawContent_tsx-app_utils_useProjectF-a8d2cf.*.js 19 bytes 108.53kB 0.02%
chunks/app_components_charts_eventsRequest_tsx-app_utils_routeAnalytics_useRouteAnalyticsEventNames_-3be7f3.*.js 23 bytes 107.78kB 0.02%
chunks/app_components_core_alert_stories_tsx.*.js 94.05kB 104.62kB 889.98% ⚠️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.eaa3059fceab8c1f51d2.js (New) 101.16kB 101.16kB 100.0% 🚀
entrypoints/app.js 66 bytes 99.41kB 0.07%
chunks/app_components_profiling_flamegraph_flamegraphTooltip_tsx-app_components_profiling_flamegraph-49a36e.*.js 143 bytes 86.58kB 0.17%
chunks/app_views_alerts_rules_utils_tsx.*.js 42 bytes 65.6kB 0.06%
chunks/app_views_monitors_components_monitorForm_tsx.*.js 5 bytes 51.93kB 0.01%
chunks/vendors-node_modules_core-js_modules_web_dom-exception_stack_js-node_modules_core-js_modules_-484e9a.*.js (New) 46.94kB 46.94kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-5531f4.*.js 18 bytes 44.51kB 0.04%
chunks/app_views_stories_index_tsx.*.js 542 bytes 43.49kB 1.26%
chunks/app_components_replays_player_styles_tsx-app_utils_replays_hooks_useLoadReplayReader_tsx.*.js -147 bytes 41.46kB -0.35%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-51a8df.*.js 18 bytes 41.09kB 0.04%
chunks/app_views_performance_newTraceDetails_traceAnalytics_tsx.*.js (New) 40.49kB 40.49kB 100.0% 🚀
chunks/app_views_alerts_list_rules_alertRulesList_tsx-node_modules_react-virtualized_dist_es_CellMea-2d6856.*.js 38 bytes 39.68kB 0.1%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b3f1e2.*.js 18 bytes 39.57kB 0.05%
chunks/app_views_insights_mobile_screens_views_screensLandingPage_tsx-app_views_insights_pages_domai-598e4f.*.js -3 bytes 39.23kB -0.01%
entrypoints/pipeline.js -30 bytes 37.45kB -0.08%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.6985b951af7fe4182d29.js (New) 37.35kB 37.35kB 100.0% 🚀
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_performance_onboarding_tsx.*.js 327 bytes 37.18kB 0.89%
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-2f190a.*.js 68 bytes 34.44kB 0.2%
chunks/app_components_core_alertLink_tsx-app_views_monitors_components_detailsSidebar_tsx-app_views_-fc3805.*.js (New) 33.99kB 33.99kB 100.0% 🚀
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_views_spans-82c131.*.js 50 bytes 33.95kB 0.15%
chunks/app_views_insights_pages_backend_backendOverviewPage_tsx-node_modules_lodash_partialRight_js.*.js -1.29kB 33.85kB -3.68%
chunks/app_views_insights_common_components_modulePageFilterBar_tsx-app_views_insights_common_compon-5dd5b5.*.js -103 bytes 31.86kB -0.32%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.e06552bb18be27b1bdef.js (New) 31.68kB 31.68kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.c8ec5a61e43080852b26.js (New) 31.18kB 31.18kB 100.0% 🚀
chunks/app_components_compactSelect_list_tsx.*.js 43 bytes 30.69kB 0.14%
chunks/vendors-node_modules_moment-timezone_index_js-node_modules_query-string_index_js-node_modules-c3aedd.*.js 722 bytes 29.46kB 2.51%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-a719f9.*.js (New) 28.39kB 28.39kB 100.0% 🚀
chunks/app_views_alerts_rules_uptime_details_tsx-node_modules_react-virtualized_dist_es_CellMeasurer-6d1558.*.js 731 bytes 27.96kB 2.69%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-4f9b0b.*.js 18 bytes 25.84kB 0.07%
chunks/app_views_explore_logs_index_tsx-node_modules_echarts_lib_chart_scatter_js-node_modules_echar-5988f7.*.js 23 bytes 25.5kB 0.09%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.b25a10265a4884c88b05.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_views_explore_contexts_pageParamsContext_index_tsx.*.js 1.24kB 23.77kB 5.49% ⚠️
chunks/app_components_events_eventTags_index_tsx.*.js -39.38kB 22.43kB -63.71%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-2fd359.*.js 18 bytes 20.31kB 0.09%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_dashboards_contexts_widgetSync-cacc8c.7ca474bd4a6da13318f9.js (New) 20.1kB 20.1kB 100.0% 🚀
chunks/app_components_modals_emailVerificationModal_tsx.*.js 19 bytes 19.77kB 0.1%
chunks/app_views_insights_common_components_headerContainer_tsx-app_views_insights_common_components-693866.*.js -103 bytes 19.73kB -0.52%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-5cb7b9.*.js -576 bytes 18.83kB -2.97%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.230e1ec3a736e8fc285a.js (New) 17.3kB 17.3kB 100.0% 🚀
chunks/app_bootstrap_initializeMain_tsx.*.js -30 bytes 17.21kB -0.17%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.dd6b060949b6927ac5de.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_views_insights_crons_views_overview_tsx.*.js -103 bytes 15.95kB -0.64%
chunks/app_views_issueDetails_groupUptimeChecks_tsx-node_modules_react-aria_utils_dist_mergeRefs_mjs.*.js 239 bytes 15.11kB 1.61%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.0e3160dcff50389f0868.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_views_settings_projectAlerts_settings_tsx.*.js 5 bytes 13.16kB 0.04%
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.cbe7a0e643399036783f.js (New) 12.33kB 12.33kB 100.0% 🚀
chunks/app_views_settings_account_accountEmails_tsx.*.js 5 bytes 10.75kB 0.05%
chunks/app_stories_storyBook_tsx.*.js -3 bytes 10.12kB -0.03%
chunks/app_components_replays_player_replayPlayer_tsx-app_components_replays_player_replayPlayerMeas-56bc66.*.js -59 bytes 9.99kB -0.59%
chunks/app_components_checkInTimeline_hooks_useTimeWindowConfig_tsx-app_views_insights_uptime_compon-1fd65a.*.js 175 bytes 9.56kB 1.87%
chunks/app_views_insights_common_components_modulePageProviders_tsx-app_views_insights_pages_domainV-906f95.*.js 721 bytes 9.47kB 8.24% ⚠️
chunks/app_components_core_alertLink_stories_tsx.*.js (New) 7.95kB 7.95kB 100.0% 🚀
chunks/app_components_events_rrwebReplayer_index_tsx.*.js 6 bytes 6.76kB 0.09%
chunks/app_views_settings_account_notifications_notificationSettingsController_tsx.*.js 5 bytes 6.16kB 0.08%
chunks/app_views_settings_organizationApiKeys_index_tsx.*.js 5 bytes 6.13kB 0.08%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-9de3f2.*.js 18 bytes 5.41kB 0.33%
chunks/app_views_settings_organizationRepositories_index_tsx.*.js 5 bytes 4.28kB 0.12%
chunks/app_components_core_alertLink_tsx.*.js (New) 3.47kB 3.47kB 100.0% 🚀
chunks/vendors-node_modules_emotion_styled_base_dist_emotion-styled-base_browser_esm_js-node_modules-0f7219.*.js (Deleted) -1.56MB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_emotion_react_jsx-runtime_dist_emotion-react-jsx-runtime_browser_esm_js--98d7e4.*.js (Deleted) -960.17kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_redirectToProject_tsx-app_bootstrap_commonInitialization_tsx-app_bootstrap-eebb3f.*.js (Deleted) -432.09kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_classnames_index_js-node_modules_lodash_debounce_js-node_modules_lodash_-bf5b2d.*.js (Deleted) -307.59kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_sentry-internal_rrweb-player_dist_index_mjs.*.js (Deleted) -116.74kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_sentry-internal_rrweb_es_rrweb_packages_rrweb_src_replay_index_js.*.js (Deleted) -108.94kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.0839d8265ad0d6b3aef0.js (Deleted) -101.16kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_core-js_modules_web_dom-exception_stack_js-node_modules_core-js_modules_-d581ce.*.js (Deleted) -46.06kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.32a9b856cff8d8724a8d.js (Deleted) -37.35kB 0 bytes -100.0% 🗑️
chunks/app_components_alertLink_tsx-app_views_monitors_components_detailsSidebar_tsx-app_views_monit-813273.*.js (Deleted) -33.97kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.102bce4691dc95b85806.js (Deleted) -31.68kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.f892f7ef6733deb44d28.js (Deleted) -31.18kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-52426c.*.js (Deleted) -29.11kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.15fc192763bb8482f293.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_dashboards_contexts_widgetS-993211.*.js (Deleted) -20.82kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.9156d48c8c1b297f46b1.js (Deleted) -17.3kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.b706ed6ecb3e39ec44ed.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.82ccfd9b06a61c305edd.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.d65e26b8f9479a43b3ab.js (Deleted) -12.33kB 0 bytes -100.0% 🗑️
chunks/app_components_alertLink_stories_tsx.*.js (Deleted) -7.93kB 0 bytes -100.0% 🗑️
chunks/app_components_alertLink_tsx.*.js (Deleted) -3.45kB 0 bytes -100.0% 🗑️

Files in chunks/app_bootstrap_initializeApp_tsx-app_components_avatar_actorAvatar_tsx-app_components_avatar_a-7c38cc.*.js:

  • ./app/views/issueDetails/streamline/foldSection.tsx → Total Size: 93.48kB

Files in chunks/app_actionCreators_members_tsx-app_components_acl_access_tsx-app_components_avatar_avatarList-1442c2.*.js:

  • ./app/views/issueDetails/streamline/foldSection.tsx → Total Size: 93.48kB

@roggenkemper roggenkemper merged commit 14554a7 into master Feb 21, 2025
44 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/updatefoldsection branch February 21, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants