-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: chonkify alert #85503
components: chonkify alert #85503
Conversation
Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
Bundle ReportChanges will increase total bundle size by 3.59kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work! Very awesome to see the ball start rolling here. 🙌
function unreachable(x: never) { | ||
return x; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a useful pattern, should this be added to the utils
directory instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, we have like 5 other instances of it, so let me move it to utils and add a comment
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
This is the first PR that takes care of converting the Alert component to a Chonky look. The PR implements a bulk of visual changes, but it is not final - I will follow up with minor tweaks and exceptions to the styles, but it will be easier to follow them as separate pull requests.