Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo-mode): use DemoSafePermission class #85444

Merged
merged 13 commits into from
Feb 21, 2025
Merged

fix(demo-mode): use DemoSafePermission class #85444

merged 13 commits into from
Feb 21, 2025

Conversation

obostjancic
Copy link
Member

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 19, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.91837% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/permissions.py 84.61% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #85444      +/-   ##
==========================================
+ Coverage   87.87%   87.95%   +0.07%     
==========================================
  Files        9672     9648      -24     
  Lines      546922   545894    -1028     
  Branches    21321    21168     -153     
==========================================
- Hits       480588   480115     -473     
+ Misses      66028    65471     -557     
- Partials      306      308       +2

@obostjancic obostjancic requested a review from a team February 19, 2025 15:31
@obostjancic obostjancic marked this pull request as ready for review February 19, 2025 15:31
@obostjancic obostjancic requested review from a team as code owners February 19, 2025 15:31
@obostjancic obostjancic changed the title fix(demo-mode): use DemoUserPermission class fix(demo-mode): use DemoSafePermission class Feb 20, 2025
shellmayr
shellmayr approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚢

@obostjancic obostjancic enabled auto-merge (squash) February 21, 2025 08:34
@obostjancic obostjancic merged commit 2723902 into master Feb 21, 2025
49 checks passed
@obostjancic obostjancic deleted the ogi/fix/readonly-user-permissions branch February 21, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellmayr shellmayr shellmayr approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obostjancic @shellmayr