ref(grouping): Add schema_version to GroupHashMetadata table
#85300
+75
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
bd7110d to
d1779e0
Compare
f7dca7f to
c217cae
Compare
d1779e0 to
558d105
Compare
c217cae to
4091f58
Compare
Base automatically changed from
kmclb-add-grouphash-metadata-to-existing-grouphashes
to
master
February 20, 2025 17:20
4091f58 to
467c959
Compare
467c959 to
5616bf8
Compare
armenzg
approved these changes
Feb 21, 2025
| @@ -53,6 +76,9 @@ class GroupHashMetadata(Model): | |||
| # When the grouphash was created. Will be null for grouphashes created before we started | |||
| # collecting metadata. | |||
| date_added = models.DateTimeField(default=timezone.now, null=True) | |||
| # The version of the metadata schema which produced the data. Useful for backfilling when we add | |||
| # to or change the data we collect and want to update existing records. | |||
| schema_version = models.CharField(null=True) | |||
There was a problem hiding this comment.
Are we planning to remove the null once all records are populated?
There was a problem hiding this comment.
it is probably not worth it as we'd have to be careful about the migration https://develop.sentry.dev/backend/application-domains/database-migrations/#adding-constraints-to-columns-including-not-null
There was a problem hiding this comment.
Agreed. It'd be nice if postgres had some sort of progressively-non-null designation we could set - so that the constraint could be checked as records are touched in the course of normal operations - but AFAIK no such thing exists, so we'll probably have to just live with the nullability. (This goes for pretty much all the fields in the table.)
5616bf8 to
8eea882
Compare
|
This PR has a migration; here is the generated SQL for --
-- Add field schema_version to grouphashmetadata
--
ALTER TABLE "sentry_grouphashmetadata" ADD COLUMN "schema_version" varchar NULL; |
8eea882 to
f0a33e7
Compare
f0a33e7 to
4e9e8e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we change or add to the data we store in grouphash metadata, we want to be able to update data for grouphashes created before a given change was made. In order to do that, we need to keep track of which version of the grouphash metadata schema was active when a given grouphash's data was collected. This therefore adds a
schema_versionfield to the table, and populates it for newGroupHashMetadatarecords.