Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): move trace section to below replay and add section title/icon #77668

Merged
merged 2 commits into from
Sep 17, 2024
Merged

ref(feedback): move trace section to below replay and add section title/icon #77668

merged 2 commits into from
Sep 17, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Sep 17, 2024 •
edited
Loading

Ref #68481. Also refactors TraceDataSection to its own file.

After:
Screenshot 2024-09-17 at 3 58 31 PM

Before:
Screenshot 2024-09-17 at 3 59 24 PM

@aliu39 aliu39 requested a review from a team as a code owner September 17, 2024 22:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 17, 2024
michellewzhang
michellewzhang approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file

@aliu39 aliu39 requested review from jas-kas and a team September 17, 2024 23:00
@aliu39
Copy link
Member Author

aliu39 commented Sep 17, 2024

new file

Yeah lol you were right the first time

@aliu39 aliu39 enabled auto-merge (squash) September 17, 2024 23:06
@aliu39 aliu39 merged commit 3db9788 into master Sep 17, 2024
43 checks passed
@aliu39 aliu39 deleted the aliu/feedback-trace-update branch September 17, 2024 23:17
harshithadurai pushed a commit that referenced this pull request Sep 19, 2024
@aliu39
ref(feedback): move trace section to below replay and add section tit…
057bf8f 
…le/icon (#77668)

Ref #68481. Also refactors
TraceDataSection to its own file.

After:
![Screenshot 2024-09-17 at 3 58
31 PM](https://github.com/user-attachments/assets/1c0cbb21-8f35-46c2-82d6-ed3c485997ae)

Before:
![Screenshot 2024-09-17 at 3 59
24 PM](https://github.com/user-attachments/assets/669e8ffd-3cce-4fb7-8f2e-2482c2e93565)
harshithadurai pushed a commit that referenced this pull request Sep 19, 2024
@aliu39
ref(feedback): move trace section to below replay and add section tit…
a535bed 
…le/icon (#77668)

Ref #68481. Also refactors
TraceDataSection to its own file.

After:
![Screenshot 2024-09-17 at 3 58
31 PM](https://github.com/user-attachments/assets/1c0cbb21-8f35-46c2-82d6-ed3c485997ae)

Before:
![Screenshot 2024-09-17 at 3 59
24 PM](https://github.com/user-attachments/assets/669e8ffd-3cce-4fb7-8f2e-2482c2e93565)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

@jas-kas jas-kas Awaiting requested review from jas-kas

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliu39 @michellewzhang